[embedded] Serialize+deserialize vtables, fix using non-generic classes from other modules in embedded Swift #68992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
reviewed
Oct 5, 2023
|
@swift-ci please test |
…es from other modules in embedded Swift
…LModule::lookUpVTable
kubamracek
force-pushed
the
embedded-serialize-vtables
branch
from
4f32c08 to
c5dd11a
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the attached testcase that demonstrates the problem: Currently, the test fails to link with a missing symbol referencing the other module's class vtable, because (1) CMO doesn't serialize vtables, (2) IRGen doesn't emit class metadata when there isn't a Decl for the class in the module.